Commit 7f85b95d authored by Jeremy Mikola's avatar Jeremy Mikola

Extra assertions and type hints in CRUD test runner

parent 88b9f6b9
...@@ -350,6 +350,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase ...@@ -350,6 +350,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase
case 'deleteMany': case 'deleteMany':
case 'deleteOne': case 'deleteOne':
$this->assertInternalType('array', $expectedResult);
$this->assertInstanceOf('MongoDB\DeleteResult', $actualResult); $this->assertInstanceOf('MongoDB\DeleteResult', $actualResult);
if (isset($expectedResult['deletedCount'])) { if (isset($expectedResult['deletedCount'])) {
...@@ -383,6 +384,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase ...@@ -383,6 +384,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase
break; break;
case 'insertOne': case 'insertOne':
$this->assertInternalType('array', $expectedResult);
$this->assertInstanceOf('MongoDB\InsertOneResult', $actualResult); $this->assertInstanceOf('MongoDB\InsertOneResult', $actualResult);
if (isset($expectedResult['insertedCount'])) { if (isset($expectedResult['insertedCount'])) {
...@@ -400,6 +402,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase ...@@ -400,6 +402,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase
case 'replaceOne': case 'replaceOne':
case 'updateMany': case 'updateMany':
case 'updateOne': case 'updateOne':
$this->assertInternalType('array', $expectedResult);
$this->assertInstanceOf('MongoDB\UpdateResult', $actualResult); $this->assertInstanceOf('MongoDB\UpdateResult', $actualResult);
if (isset($expectedResult['matchedCount'])) { if (isset($expectedResult['matchedCount'])) {
...@@ -489,7 +492,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase ...@@ -489,7 +492,7 @@ class CrudSpecFunctionalTest extends FunctionalTestCase
* @param array $arguments * @param array $arguments
* @return array * @return array
*/ */
private function prepareFindAndModifyArguments($arguments) private function prepareFindAndModifyArguments(array $arguments)
{ {
if (isset($arguments['returnDocument'])) { if (isset($arguments['returnDocument'])) {
$arguments['returnDocument'] = ('after' === strtolower($arguments['returnDocument'])) $arguments['returnDocument'] = ('after' === strtolower($arguments['returnDocument']))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment