Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Contribute to GitLab
Sign in
Toggle navigation
M
mongo-php-library
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
sinan
mongo-php-library
Commits
6b950169
Commit
6b950169
authored
Dec 23, 2015
by
Jeremy Mikola
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
CreateIndexes can require that $indexes be a list
parent
7239ab74
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
2 deletions
+19
-2
CreateIndexes.php
src/Operation/CreateIndexes.php
+9
-1
CreateIndexesTest.php
tests/Operation/CreateIndexesTest.php
+10
-1
No files found.
src/Operation/CreateIndexes.php
View file @
6b950169
...
...
@@ -40,7 +40,13 @@ class CreateIndexes implements Executable
throw
new
InvalidArgumentException
(
'$indexes is empty'
);
}
foreach
(
$indexes
as
$index
)
{
$expectedIndex
=
0
;
foreach
(
$indexes
as
$i
=>
$index
)
{
if
(
$i
!==
$expectedIndex
)
{
throw
new
InvalidArgumentException
(
sprintf
(
'$indexes is not a list (unexpected index: "%s")'
,
$i
));
}
if
(
!
is_array
(
$index
))
{
throw
new
InvalidArgumentTypeException
(
sprintf
(
'$index[%d]'
,
$i
),
$index
,
'array'
);
}
...
...
@@ -50,6 +56,8 @@ class CreateIndexes implements Executable
}
$this
->
indexes
[]
=
new
IndexInput
(
$index
);
$expectedIndex
+=
1
;
}
$this
->
databaseName
=
(
string
)
$databaseName
;
...
...
tests/Operation/CreateIndexesTest.php
View file @
6b950169
...
...
@@ -16,7 +16,16 @@ class CreateIndexesTest extends TestCase
}
/**
* @expectedException MongoDB\Exception\UnexpectedTypeException
* @expectedException MongoDB\Exception\InvalidArgumentException
* @expectedExceptionMessage $indexes is not a list (unexpected index: "1")
*/
public
function
testConstructorIndexesArgumentMustBeAList
()
{
new
CreateIndexes
(
$this
->
getDatabaseName
(),
$this
->
getCollectionName
(),
[
1
=>
[
'key'
=>
[
'x'
=>
1
]]]);
}
/**
* @expectedException MongoDB\Exception\InvalidArgumentTypeException
* @dataProvider provideInvalidIndexSpecificationTypes
*/
public
function
testCreateIndexesRequiresIndexSpecificationsToBeAnArray
(
$index
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment