Commit 83d0b8b4 authored by Matthieu Fauveau's avatar Matthieu Fauveau Committed by Jens Segers

Adds support for _id of binary type (#1611)

parent fdf7f67b
...@@ -9,6 +9,7 @@ use Illuminate\Database\Eloquent\Relations\Relation; ...@@ -9,6 +9,7 @@ use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Support\Arr; use Illuminate\Support\Arr;
use Illuminate\Support\Str; use Illuminate\Support\Str;
use Jenssegers\Mongodb\Query\Builder as QueryBuilder; use Jenssegers\Mongodb\Query\Builder as QueryBuilder;
use MongoDB\BSON\Binary;
use MongoDB\BSON\ObjectID; use MongoDB\BSON\ObjectID;
use MongoDB\BSON\UTCDateTime; use MongoDB\BSON\UTCDateTime;
use Illuminate\Contracts\Queue\QueueableEntity; use Illuminate\Contracts\Queue\QueueableEntity;
...@@ -63,6 +64,8 @@ abstract class Model extends BaseModel ...@@ -63,6 +64,8 @@ abstract class Model extends BaseModel
// Convert ObjectID to string. // Convert ObjectID to string.
if ($value instanceof ObjectID) { if ($value instanceof ObjectID) {
return (string) $value; return (string) $value;
} elseif ($value instanceof Binary) {
return (string) $value->getData();
} }
return $value; return $value;
...@@ -172,7 +175,7 @@ abstract class Model extends BaseModel ...@@ -172,7 +175,7 @@ abstract class Model extends BaseModel
public function setAttribute($key, $value) public function setAttribute($key, $value)
{ {
// Convert _id to ObjectID. // Convert _id to ObjectID.
if ($key == '_id' && is_string($value)) { if (($key == '_id' || Str::endsWith($key, '_id')) && is_string($value)) {
$builder = $this->newBaseQueryBuilder(); $builder = $this->newBaseQueryBuilder();
$value = $builder->convertKey($value); $value = $builder->convertKey($value);
...@@ -204,6 +207,8 @@ abstract class Model extends BaseModel ...@@ -204,6 +207,8 @@ abstract class Model extends BaseModel
foreach ($attributes as $key => &$value) { foreach ($attributes as $key => &$value) {
if ($value instanceof ObjectID) { if ($value instanceof ObjectID) {
$value = (string) $value; $value = (string) $value;
} elseif ($value instanceof Binary) {
$value = (string) $value->getData();
} }
} }
......
...@@ -11,6 +11,7 @@ use Illuminate\Support\Collection; ...@@ -11,6 +11,7 @@ use Illuminate\Support\Collection;
use Illuminate\Support\Str; use Illuminate\Support\Str;
use Jenssegers\Mongodb\Connection; use Jenssegers\Mongodb\Connection;
use MongoCollection; use MongoCollection;
use MongoDB\BSON\Binary;
use MongoDB\BSON\ObjectID; use MongoDB\BSON\ObjectID;
use MongoDB\BSON\Regex; use MongoDB\BSON\Regex;
use MongoDB\BSON\UTCDateTime; use MongoDB\BSON\UTCDateTime;
...@@ -843,6 +844,8 @@ class Builder extends BaseBuilder ...@@ -843,6 +844,8 @@ class Builder extends BaseBuilder
{ {
if (is_string($id) && strlen($id) === 24 && ctype_xdigit($id)) { if (is_string($id) && strlen($id) === 24 && ctype_xdigit($id)) {
return new ObjectID($id); return new ObjectID($id);
} elseif (strlen($id) === 16 && preg_match('~[^\x20-\x7E\t\r\n]~', $id) > 0) {
return new Binary($id, Binary::TYPE_UUID);
} }
return $id; return $id;
...@@ -903,7 +906,7 @@ class Builder extends BaseBuilder ...@@ -903,7 +906,7 @@ class Builder extends BaseBuilder
} }
// Convert id's. // Convert id's.
if (isset($where['column']) && ($where['column'] == '_id' || Str::endsWith($where['column'], '._id'))) { if (isset($where['column']) && ($where['column'] == '_id' || Str::endsWith($where['column'], '_id'))) {
// Multiple values. // Multiple values.
if (isset($where['values'])) { if (isset($where['values'])) {
foreach ($where['values'] as &$value) { foreach ($where['values'] as &$value) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment