Skip to content

M
mongo-php-library
Commit adff7f0f authored by Jeremy Mikola's avatar Jeremy Mikola
Browse files
Options

PHPLIB-92: bulkWrite() updates should use "multi" option

parent 5d1686fe
Show whitespace changes
Inline Side-by-side
Showing with 3 additions and 3 deletions
src/Collection.php
View file @ adff7f0f
...@@ -223,7 +223,7 @@ class Collection ...@@ -223,7 +223,7 @@ class Collection
if (!isset($args[1])) { if (!isset($args[1])) {
throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n)); throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n));
} }
$options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("limit" => 0)); $options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("multi" => true));
$bulk->update($args[0], $args[1], $options); $bulk->update($args[0], $args[1], $options);
break; break;
...@@ -232,7 +232,7 @@ class Collection ...@@ -232,7 +232,7 @@ class Collection
if (!isset($args[1])) { if (!isset($args[1])) {
throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n)); throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n));
} }
$options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("limit" => 1)); $options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("multi" => false));
$firstKey = key($args[1]); $firstKey = key($args[1]);
if (!isset($firstKey[0]) || $firstKey[0] != '$') { if (!isset($firstKey[0]) || $firstKey[0] != '$') {
throw new InvalidArgumentException("First key in \$update must be a \$operator"); throw new InvalidArgumentException("First key in \$update must be a \$operator");
...@@ -245,7 +245,7 @@ class Collection ...@@ -245,7 +245,7 @@ class Collection
if (!isset($args[1])) { if (!isset($args[1])) {
throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n)); throw new InvalidArgumentException(sprintf("Missing argument#2 for '%s' (operation#%d)", $opname, $n));
} }
$options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("limit" => 1)); $options = array_merge($this->getWriteOptions(), isset($args[2]) ? $args[2] : array(), array("multi" => false));
$firstKey = key($args[1]); $firstKey = key($args[1]);
if (isset($firstKey[0]) && $firstKey[0] == '$') { if (isset($firstKey[0]) && $firstKey[0] == '$') {
throw new InvalidArgumentException("First key in \$update must NOT be a \$operator"); throw new InvalidArgumentException("First key in \$update must NOT be a \$operator");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment