Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Contribute to GitLab
Sign in
Toggle navigation
M
mongo-php-library
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
sinan
mongo-php-library
Commits
2083eede
Commit
2083eede
authored
Apr 24, 2015
by
Jeremy Mikola
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
PHPLIB-63: Empty input to createIndexes() is a NOP
parent
39cf9182
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
0 deletions
+9
-0
Collection.php
src/Collection.php
+4
-0
CollectionFunctionalTest.php
tests/CollectionFunctionalTest.php
+5
-0
No files found.
src/Collection.php
View file @
2083eede
...
@@ -290,6 +290,10 @@ class Collection
...
@@ -290,6 +290,10 @@ class Collection
*/
*/
public
function
createIndexes
(
array
$indexes
)
public
function
createIndexes
(
array
$indexes
)
{
{
if
(
empty
(
$indexes
))
{
return
array
();
}
foreach
(
$indexes
as
$i
=>
$index
)
{
foreach
(
$indexes
as
$i
=>
$index
)
{
if
(
!
is_array
(
$index
))
{
if
(
!
is_array
(
$index
))
{
throw
new
UnexpectedTypeException
(
$index
,
'array'
);
throw
new
UnexpectedTypeException
(
$index
,
'array'
);
...
...
tests/CollectionFunctionalTest.php
View file @
2083eede
...
@@ -132,6 +132,11 @@ class CollectionFunctionalTest extends FunctionalTestCase
...
@@ -132,6 +132,11 @@ class CollectionFunctionalTest extends FunctionalTestCase
});
});
}
}
public
function
testCreateIndexesWithEmptyInputIsNop
()
{
$this
->
assertSame
(
array
(),
$this
->
collection
->
createIndexes
(
array
()));
}
public
function
testDropIndex
()
public
function
testDropIndex
()
{
{
$this
->
assertSame
(
'x_1'
,
$this
->
collection
->
createIndex
(
array
(
'x'
=>
1
)));
$this
->
assertSame
(
'x_1'
,
$this
->
collection
->
createIndex
(
array
(
'x'
=>
1
)));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment