Slimming down the BelongsToMany class

src/Jenssegers/Mongodb/Relations/BelongsToMany.php

 <?php namespace Jenssegers\Mongodb\Relations;
+
 use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Model;
@@ -7,29 +8,14 @@ use Illuminate\Database\Eloquent\Relations\BelongsToMany as EloquentBelongsToMan
 class BelongsToMany extends EloquentBelongsToMany {
 
 	/**
-	 * Execute the query as a "select" statement.
+	 * Hydrate the pivot table relationship on the models.
 	 *
-	 * @param  array  $columns
-	 * @return \Illuminate\Database\Eloquent\Collection
+	 * @param  array  $models
+	 * @return void
 	 */
-	public function get($columns = array('*'))
-	{
-		// First we'll add the proper select columns onto the query so it is run with
-		// the proper columns. Then, we will get the results and hydrate out pivot
-		// models with the result of those columns as a separate model relation.
-		$select = $this->getSelectColumns($columns);
-
-		$models = $this->query->addSelect($select)->getModels();
-
-		// If we actually found models we will also eager load any relationships that
-		// have been specified as needing to be eager loaded. This will solve the
-		// n + 1 query problem for the developer and also increase performance.
-		if (count($models) > 0)
+	protected function hydratePivotRelation(array $models)
 	{
-			$models = $this->query->eagerLoadRelations($models);
-		}
-
-		return $this->related->newCollection($models);
+		// Do nothing
 	}
 
 	/**
@@ -42,26 +28,6 @@ class BelongsToMany extends EloquentBelongsToMany {
 		return $columns;
 	}
 
-	/**
-	 * Get a paginator for the "select" statement.
-	 *
-	 * @param  int    $perPage
-	 * @param  array  $columns
-	 * @return \Illuminate\Pagination\Paginator
-	 */
-	public function paginate($perPage = null, $columns = array('*'))
-	{
-		$this->query->addSelect($this->getSelectColumns($columns));
-
-		// When paginating results, we need to add the pivot columns to the query and
-		// then hydrate into the pivot objects once the results have been gathered
-		// from the database since this isn't performed by the Eloquent builder.
-		$pager = $this->query->paginate($perPage, $columns);
-
-		return $pager;
-	}
-
-
 	/**
 	 * Set the base constraints on the relation query.
 	 *
@@ -77,55 +43,6 @@ class BelongsToMany extends EloquentBelongsToMany {
 		}
 	}
 
-	/**
-	 * Set the constraints for an eager load of the relation.
-	 *
-	 * @param  array  $models
-	 * @return void
-	 */
-	public function addEagerConstraints(array $models)
-	{
-		$this->query->whereIn($this->getForeignKey(), $this->getKeys($models));
-	}
-
-	/**
-	 * Save a new model and attach it to the parent model.
-	 *
-	 * @param  \Illuminate\Database\Eloquent\Model  $model
-	 * @param  array  $joining
-	 * @param  bool   $touch
-	 * @return \Illuminate\Database\Eloquent\Model
-	 */
-	public function save(Model $model, array $joining = array(), $touch = true)
-	{
-		$model->save(array('touch' => false));
-
-		$this->attach($model->getKey(), $joining, $touch);
-		
-		return $model;
-	}
-
-	/**
-	 * Create a new instance of the related model.
-	 *
-	 * @param  array  $attributes
-	 * @param  array  $joining
-	 * @param  bool   $touch
-	 * @return \Illuminate\Database\Eloquent\Model
-	 */
-	public function create(array $attributes, array $joining = array(), $touch = true)
-	{
-		$instance = $this->related->newInstance($attributes);
-
-		// Save the new instance before we attach it to other models	
-		$instance->save(array('touch' => false));
-		
-		// Attach to the parent instance
-		$this->attach($instance->_id, $attributes, $touch);
-
-		return $instance;
-	}
-
 	/**
 	 * Sync the intermediate tables with a list of IDs.
 	 *
@@ -164,29 +81,6 @@ class BelongsToMany extends EloquentBelongsToMany {
 		$this->touchIfTouching();
 	}
 
-	/**
-	 * Format the sync list so that it is keyed by ID.
-	 *
-	 * @param  array  $records
-	 * @return array
-	 */
-	protected function formatSyncList(array $records)
-	{
-		$results = array();
-
-		foreach ($records as $id => $attributes)
-		{
-			if ( ! is_array($attributes))
-			{
-				list($id, $attributes) = array($attributes, array());
-			}
-
-			$results[$id] = $attributes;
-		}
-
-		return $results;
-	}
-
 	/**
 	 * Attach all of the IDs that aren't in the current array.
 	 *
@@ -300,38 +194,6 @@ class BelongsToMany extends EloquentBelongsToMany {
 		return count($ids);
 	}
 
-	/**
-	 * If we're touching the parent model, touch.
-	 *
-	 * @return void
-	 */
-	public function touchIfTouching()
-	{ 
-	 	if ($this->touchingParent()) $this->getParent()->touch();
-
-	 	if ($this->getParent()->touches($this->relationName)) $this->touch();
-	}
-
-	/**
-	 * Determine if we should touch the parent on sync.
-	 *
-	 * @return bool
-	 */
-	protected function touchingParent()
-	{
-		return $this->getRelated()->touches($this->guessInverseRelation());
-	}
-
-	/**
-	 * Attempt to guess the name of the inverse of the relation.
-	 *
-	 * @return string
-	 */
-	protected function guessInverseRelation()
-	{
-		return strtolower(str_plural(class_basename($this->getParent())));
-	}
-
 	/**
 	 * Create a new query builder for the parent
 	 *
@@ -370,16 +232,6 @@ class BelongsToMany extends EloquentBelongsToMany {
 		return $dictionary;
 	}
 
-	/**
-	 * Get the related model's updated at column name.
-	 *
-	 * @return string
-	 */
-	public function getRelatedFreshUpdate()
-	{
-		return array($this->related->getUpdatedAtColumn() => $this->related->freshTimestamp());
-	}
-
 	/**
 	 * Get the fully qualified foreign key for the relation.
 	 *

tests/RelationsTest.php

@@ -31,7 +31,7 @@ class RelationsTest extends PHPUnit_Framework_TestCase {
 
         $items = $user->items;
         $this->assertEquals(3, count($items));
-    }
+}
 
     public function testBelongsTo()
     {